Session versioning support#2718
Closed
lprimak wants to merge 8 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds “session versioning” plumbing across core and web modules to help prevent stale session updates (notably around caching/native sessions) by propagating a versioning flag through session creation and introducing version-aware cache writes.
Changes:
- Introduces
VersionedSessionand wires a “versioned” flag fromSecurityManager/SessionManager→SessionContext→SimpleSession. - Updates native session/web request flow to increment a session version (and adds
incrementVersiontoNativeSessionManager). - Updates
CachingSessionDAOto avoid overwriting a cached session with an older version.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/main/java/org/apache/shiro/web/subject/support/WebDelegatingSubject.java | Propagates versioning flag into WebSessionContext during session creation. |
| web/src/main/java/org/apache/shiro/web/session/mgt/ServletContainerSessionManager.java | Declares servlet-container sessions as non-versioned. |
| web/src/main/java/org/apache/shiro/web/servlet/AbstractShiroFilter.java | Adds request-end version increment hook for native sessions. |
| core/src/test/java/org/apache/shiro/session/mgt/AbstractValidatingSessionManagerTest.java | Updates test stub session manager for new isVersioned() API. |
| core/src/main/java/org/apache/shiro/subject/support/DelegatingSubject.java | Propagates versioning flag into SessionContext during session creation. |
| core/src/main/java/org/apache/shiro/session/mgt/VersionedSession.java | New interface defining version-aware session operations. |
| core/src/main/java/org/apache/shiro/session/mgt/SimpleSessionFactory.java | Creates SimpleSession using host + versioned flag from SessionContext. |
| core/src/main/java/org/apache/shiro/session/mgt/SimpleSession.java | Implements versioning and introduces atomic/concurrent structures + serialization changes. |
| core/src/main/java/org/apache/shiro/session/mgt/SessionManager.java | Adds isVersioned() API to drive version-aware session creation. |
| core/src/main/java/org/apache/shiro/session/mgt/SessionContext.java | Adds versioned flag getters/setters to session context. |
| core/src/main/java/org/apache/shiro/session/mgt/NativeSessionManager.java | Adds incrementVersion(SessionKey) API for native session managers. |
| core/src/main/java/org/apache/shiro/session/mgt/eis/CachingSessionDAO.java | Adds version-aware cache put logic to avoid caching stale sessions. |
| core/src/main/java/org/apache/shiro/session/mgt/DefaultSessionManager.java | Implements isVersioned() based on DAO type (caching DAO). |
| core/src/main/java/org/apache/shiro/session/mgt/DefaultSessionContext.java | Stores/retrieves the “versioned session” flag in the context map. |
| core/src/main/java/org/apache/shiro/session/mgt/AbstractNativeSessionManager.java | Implements incrementVersion for versioned sessions. |
| core/src/main/java/org/apache/shiro/mgt/DefaultSecurityManager.java | Propagates versioning into SessionContext and exposes isVersioned(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
There is no need to version Shiro-native session, since the session is not saved for the duration of the request like Payara sessions are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.